Implement display artifacts, pricing integrity, draft base and publish preview bundle

backend/app/api/routes/pricing.py

@@ -1,4 +1,6 @@
-from fastapi import APIRouter, Depends
+from decimal import Decimal
+
+from fastapi import APIRouter, Depends, HTTPException, status
 
 from app.core.config import settings
 from app.repositories.audit import create_audit_event
@@ -12,33 +14,44 @@ from app.repositories.pricing import (
     update_price_rule,
     update_pricing_category,
 )
+from app.repositories.scheme_version_pricing import replace_scheme_version_pricing_snapshot
 from app.repositories.schemes import get_scheme_record_by_scheme_id
+from app.repositories.scheme_versions import get_current_scheme_version
 from app.schemas.pricing import (
-    DeleteResponse,
     PriceRuleCreateRequest,
-    PriceRuleCreateResponse,
     PriceRuleItem,
     PriceRuleUpdateRequest,
-    PriceRuleUpdateResponse,
+    PricingBundleResponse,
     PricingCategoryCreateRequest,
-    PricingCategoryCreateResponse,
     PricingCategoryItem,
     PricingCategoryUpdateRequest,
-    PricingCategoryUpdateResponse,
-    SchemePricingResponse,
 )
 from app.security.auth import require_api_key
 
 router = APIRouter()
 
 
-@router.get(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing", response_model=SchemePricingResponse)
-async def get_scheme_pricing(scheme_id: str, role: str = Depends(require_api_key)):
-    await get_scheme_record_by_scheme_id(scheme_id)
+async def _refresh_current_draft_snapshot_if_possible(scheme_id: str) -> dict | None:
+    scheme = await get_scheme_record_by_scheme_id(scheme_id)
+    version = await get_current_scheme_version(
+        scheme_id=scheme.scheme_id,
+        current_version_number=scheme.current_version_number,
+    )
+    if scheme.status != "draft" or version.status != "draft":
+        return None
+
+    return await replace_scheme_version_pricing_snapshot(
+        scheme_id=scheme.scheme_id,
+        scheme_version_id=version.scheme_version_id,
+    )
+
+
+@router.get(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing", response_model=PricingBundleResponse)
+async def get_pricing_bundle(scheme_id: str, role: str = Depends(require_api_key)):
     categories = await list_pricing_categories(scheme_id)
     rules = await list_price_rules(scheme_id)
 
-    return SchemePricingResponse(
+    return PricingBundleResponse(
         categories=[
             PricingCategoryItem(
                 pricing_category_id=row.pricing_category_id,
@@ -56,7 +69,7 @@ async def get_scheme_pricing(scheme_id: str, role: str = Depends(require_api_key
                 pricing_category_id=row.pricing_category_id,
                 target_type=row.target_type,
                 target_ref=row.target_ref,
-                amount=row.amount,
+                amount=str(row.amount),
                 currency=row.currency,
                 created_at=row.created_at.isoformat(),
             )
@@ -65,34 +78,36 @@ async def get_scheme_pricing(scheme_id: str, role: str = Depends(require_api_key
     )
 
 
-@router.post(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/categories", response_model=PricingCategoryCreateResponse)
+@router.post(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/categories")
 async def create_pricing_category_endpoint(
     scheme_id: str,
     payload: PricingCategoryCreateRequest,
     role: str = Depends(require_api_key),
 ):
-    await get_scheme_record_by_scheme_id(scheme_id)
     pricing_category_id = await create_pricing_category(
         scheme_id=scheme_id,
         name=payload.name,
         code=payload.code,
     )
+    snapshot = await _refresh_current_draft_snapshot_if_possible(scheme_id)
+
     await create_audit_event(
         scheme_id=scheme_id,
         event_type="pricing.category.created",
         object_type="pricing_category",
         object_ref=pricing_category_id,
-        details={"name": payload.name, "code": payload.code},
-    )
-    return PricingCategoryCreateResponse(
-        pricing_category_id=pricing_category_id,
-        scheme_id=scheme_id,
-        name=payload.name,
-        code=payload.code,
+        details={"name": payload.name, "code": payload.code, "snapshot": snapshot},
     )
 
+    return {
+        "pricing_category_id": pricing_category_id,
+        "scheme_id": scheme_id,
+        "name": payload.name,
+        "code": payload.code,
+    }
 
-@router.put(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/categories/{{pricing_category_id}}", response_model=PricingCategoryUpdateResponse)
+
+@router.put(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/categories/{{pricing_category_id}}")
 async def update_pricing_category_endpoint(
     scheme_id: str,
     pricing_category_id: str,
@@ -105,53 +120,71 @@ async def update_pricing_category_endpoint(
         name=payload.name,
         code=payload.code,
     )
+    snapshot = await _refresh_current_draft_snapshot_if_possible(scheme_id)
+
     await create_audit_event(
         scheme_id=scheme_id,
         event_type="pricing.category.updated",
         object_type="pricing_category",
         object_ref=pricing_category_id,
-        details={"name": payload.name, "code": payload.code},
-    )
-    return PricingCategoryUpdateResponse(
-        pricing_category_id=row.pricing_category_id,
-        scheme_id=row.scheme_id,
-        name=row.name,
-        code=row.code,
+        details={"name": payload.name, "code": payload.code, "snapshot": snapshot},
     )
 
+    return {
+        "pricing_category_id": row.pricing_category_id,
+        "scheme_id": row.scheme_id,
+        "name": row.name,
+        "code": row.code,
+    }
 
-@router.delete(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/categories/{{pricing_category_id}}", response_model=DeleteResponse)
+
+@router.delete(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/categories/{{pricing_category_id}}")
 async def delete_pricing_category_endpoint(
     scheme_id: str,
     pricing_category_id: str,
     role: str = Depends(require_api_key),
 ):
-    await delete_pricing_category(scheme_id=scheme_id, pricing_category_id=pricing_category_id)
+    await delete_pricing_category(
+        scheme_id=scheme_id,
+        pricing_category_id=pricing_category_id,
+    )
+    snapshot = await _refresh_current_draft_snapshot_if_possible(scheme_id)
+
     await create_audit_event(
         scheme_id=scheme_id,
         event_type="pricing.category.deleted",
         object_type="pricing_category",
         object_ref=pricing_category_id,
-        details=None,
+        details={"snapshot": snapshot},
     )
-    return DeleteResponse(status="deleted")
+
+    return {"deleted": True, "pricing_category_id": pricing_category_id}
 
 
-@router.post(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/rules", response_model=PriceRuleCreateResponse)
+@router.post(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/rules")
 async def create_price_rule_endpoint(
     scheme_id: str,
     payload: PriceRuleCreateRequest,
     role: str = Depends(require_api_key),
 ):
-    await get_scheme_record_by_scheme_id(scheme_id)
+    try:
+        amount = Decimal(payload.amount)
+    except Exception:
+        raise HTTPException(
+            status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
+            detail="Некорректная сумма",
+        )
+
     price_rule_id = await create_price_rule(
         scheme_id=scheme_id,
         pricing_category_id=payload.pricing_category_id,
         target_type=payload.target_type,
         target_ref=payload.target_ref,
-        amount=payload.amount,
+        amount=amount,
         currency=payload.currency,
     )
+    snapshot = await _refresh_current_draft_snapshot_if_possible(scheme_id)
+
     await create_audit_event(
         scheme_id=scheme_id,
         event_type="pricing.rule.created",
@@ -161,37 +194,49 @@ async def create_price_rule_endpoint(
             "pricing_category_id": payload.pricing_category_id,
             "target_type": payload.target_type,
             "target_ref": payload.target_ref,
-            "amount": str(payload.amount),
+            "amount": payload.amount,
             "currency": payload.currency,
+            "snapshot": snapshot,
         },
     )
-    return PriceRuleCreateResponse(
-        price_rule_id=price_rule_id,
-        scheme_id=scheme_id,
-        pricing_category_id=payload.pricing_category_id,
-        target_type=payload.target_type,
-        target_ref=payload.target_ref,
-        amount=payload.amount,
-        currency=payload.currency,
-    )
+
+    return {
+        "price_rule_id": price_rule_id,
+        "scheme_id": scheme_id,
+        "pricing_category_id": payload.pricing_category_id,
+        "target_type": payload.target_type,
+        "target_ref": payload.target_ref,
+        "amount": payload.amount,
+        "currency": payload.currency,
+    }
 
 
-@router.put(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/rules/{{price_rule_id}}", response_model=PriceRuleUpdateResponse)
+@router.put(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/rules/{{price_rule_id}}")
 async def update_price_rule_endpoint(
     scheme_id: str,
     price_rule_id: str,
     payload: PriceRuleUpdateRequest,
     role: str = Depends(require_api_key),
 ):
+    try:
+        amount = Decimal(payload.amount)
+    except Exception:
+        raise HTTPException(
+            status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
+            detail="Некорректная сумма",
+        )
+
     row = await update_price_rule(
         scheme_id=scheme_id,
         price_rule_id=price_rule_id,
         pricing_category_id=payload.pricing_category_id,
         target_type=payload.target_type,
         target_ref=payload.target_ref,
-        amount=payload.amount,
+        amount=amount,
         currency=payload.currency,
     )
+    snapshot = await _refresh_current_draft_snapshot_if_possible(scheme_id)
+
     await create_audit_event(
         scheme_id=scheme_id,
         event_type="pricing.rule.updated",
@@ -201,33 +246,41 @@ async def update_price_rule_endpoint(
             "pricing_category_id": payload.pricing_category_id,
             "target_type": payload.target_type,
             "target_ref": payload.target_ref,
-            "amount": str(payload.amount),
+            "amount": payload.amount,
             "currency": payload.currency,
+            "snapshot": snapshot,
         },
     )
-    return PriceRuleUpdateResponse(
-        price_rule_id=row.price_rule_id,
-        scheme_id=row.scheme_id,
-        pricing_category_id=row.pricing_category_id,
-        target_type=row.target_type,
-        target_ref=row.target_ref,
-        amount=row.amount,
-        currency=row.currency,
-    )
+
+    return {
+        "price_rule_id": row.price_rule_id,
+        "scheme_id": row.scheme_id,
+        "pricing_category_id": row.pricing_category_id,
+        "target_type": row.target_type,
+        "target_ref": row.target_ref,
+        "amount": str(row.amount),
+        "currency": row.currency,
+    }
 
 
-@router.delete(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/rules/{{price_rule_id}}", response_model=DeleteResponse)
+@router.delete(f"{settings.api_v1_prefix}/schemes/{{scheme_id}}/pricing/rules/{{price_rule_id}}")
 async def delete_price_rule_endpoint(
     scheme_id: str,
     price_rule_id: str,
     role: str = Depends(require_api_key),
 ):
-    await delete_price_rule(scheme_id=scheme_id, price_rule_id=price_rule_id)
+    await delete_price_rule(
+        scheme_id=scheme_id,
+        price_rule_id=price_rule_id,
+    )
+    snapshot = await _refresh_current_draft_snapshot_if_possible(scheme_id)
+
     await create_audit_event(
         scheme_id=scheme_id,
         event_type="pricing.rule.deleted",
         object_type="price_rule",
         object_ref=price_rule_id,
-        details=None,
+        details={"snapshot": snapshot},
     )
-    return DeleteResponse(status="deleted")
+
+    return {"deleted": True, "price_rule_id": price_rule_id}